This repository was archived by the owner on Jul 7, 2023. It is now read-only.
Enable depth_k != depth_v in local_attention_2d and masked_local_attention_2d#1899
Open
sgrigory wants to merge 1 commit intotensorflow:masterfrom
Open
Enable depth_k != depth_v in local_attention_2d and masked_local_attention_2d#1899sgrigory wants to merge 1 commit intotensorflow:masterfrom
sgrigory wants to merge 1 commit intotensorflow:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
@googlebot I signed it! |
bishalbaaniya123
approved these changes
Mar 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves a TODO in tensor2tensor/layers/common_attention_test.py : enable
depth_v != depth_kforcommon_attention.local_attention_2dandcommon_attention.masked_local_attention_2dModification is simple: one just needs to alter the shape passed to
scatter_blocks_2dwhen generating the output, so that its last dimension is taken fromv, and notqTests:
pytest tensor2tensor/layers/common_attention_test.py tensor2tensor/layers/common_image_attention_test.pypassesvis split along the depth dimension, then applyinglocal_attention_2don each of the two parts separately and concatenating the results should be equivalent to applyinglocal_attention_2dwith originalv- see the code belowExpand sanity check code and output